Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for async validators #18

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

rhutchison
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Add support for async validators. When an async validator executes, it won't show errors until the field is blurred (if blur enabeld), or the form is submitted. This defeats the purpose of using async validators.

Issue Number: N/A

What is the new behavior?

When an async validator is fired, it will show errors if the control is INVALID. Also introduced a new property to disable (similar to blur) - [controlErrorsOnAsync]="false"

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants