Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(directive): a new custom attribute on a field #12

Merged
merged 5 commits into from
Jun 22, 2020

Conversation

mlc-mlapis
Copy link
Contributor

Skips instantiating of a control error component.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Feature

What is the current behavior?

A separate error message was created for each radio button in a radio group, and it means showing many duplicates.

What is the new behavior?

By using a new attribute controlErrorsIgnore placed on a form field, it's possible to skip the creation of such an error message and let it be only on one of them.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Skips instantiating of a control error component.
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/app/app.component.html Outdated Show resolved Hide resolved
@NetanelBasal
Copy link
Member

Add yourself as a contributor: npm run contributors:add

@NetanelBasal NetanelBasal merged commit 080455f into ngneat:master Jun 22, 2020
@mlc-mlapis mlc-mlapis deleted the ML-Custom_Ignore_Some_Elements branch June 22, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants