Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async validator work #84

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix: async validator work #84

merged 2 commits into from
Sep 20, 2022

Conversation

Sir-J
Copy link
Contributor

@Sir-J Sir-J commented Sep 20, 2022

Fix async validator work in conjunction with Validators.required

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

If we are add for one control Required and any async validator, control will be have Required error on start

Issue Number: 41

What is the new behavior?

Async and Required validator work correctly

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sergey Rogachev added 2 commits September 20, 2022 12:54
Fix async validator work in conjunction with Validators.required
@NetanelBasal NetanelBasal merged commit 3f5b4dd into ngneat:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants