fix: async validator work (#84)

* fix: async validator work Fix async validator work in conjunction with Validators.required * fix: remove empty pipe Co-authored-by: Sergey Rogachev <[email protected]>
ngneat · Sep 20, 2022 · 3f5b4dd · 3f5b4dd
1 parent 8a037e2
commit 3f5b4dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/projects/ngneat/error-tailor/src/lib/control-error.directive.spec.ts b/projects/ngneat/error-tailor/src/lib/control-error.directive.spec.ts
@@ -79,7 +79,7 @@ describe('ControlErrorDirective', () => {
  ignored: ['', Validators.required],
  explicit: [''],
  names: this.builder.array([this.createName(), this.createName()], this.validator),
- username: ['', null, this.usernameValidator.bind(this)],
+ username: ['', Validators.required, this.usernameValidator.bind(this)],
  onSubmitOnly: ['', [Validators.required]],
  onEveryChange: ['', [Validators.required]]
  });
@@ -123,6 +123,8 @@ describe('ControlErrorDirective', () => {
 
  it('should show errors on interactions', () => {
  const nameInput = spectator.query<HTMLInputElement>(byPlaceholder('Name'));
+ const usernameInput = spectator.query<HTMLInputElement>(byPlaceholder('Username'));
+ typeInElementAndFocusOut(spectator, 'async', usernameInput);
 
  typeInElementAndFocusOut(spectator, 't', nameInput);
 

diff --git a/projects/ngneat/error-tailor/src/lib/control-error.directive.ts b/projects/ngneat/error-tailor/src/lib/control-error.directive.ts
@@ -91,7 +91,7 @@ export class ControlErrorsDirective implements OnInit, OnDestroy {
 
  if (this.mergedConfig.controlErrorsOn.async && hasAsyncValidator) {
  // hasAsyncThenUponStatusChange
- changesOnAsync$ = statusChanges$.pipe(startWith(true));
+ changesOnAsync$ = statusChanges$;
  }
 
  if (this.isInput && this.mergedConfig.controlErrorsOn.change) {