feat: allow passing existing HttpContext to withCache function
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetanelBasal
reviewed
Jul 8, 2021
NetanelBasal
reviewed
Jul 8, 2021
README.md
Outdated
| } | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Please mention the alternative way.
| @@ -16,8 +16,8 @@ export interface ContextOptions { | |||
|
|
|||
| export const CACHE_CONTEXT = new HttpContextToken<ContextOptions>(() => ({})); | |||
|
|
|||
| export function withCache(options: ContextOptions = {}) { | |||
| return new HttpContext().set(CACHE_CONTEXT, { | |||
| export function withCache(options: ContextOptions = {}, existingHttpContext?: HttpContext) { | |||
There was a problem hiding this comment.
I prefer to add it as an option. I don't like the withCache({}, context) style.
Take it from the options and delete it afterward.
Co-authored-by: Netanel Basal <[email protected]>
|
I've already updated the code by moving the second argument to the option object (and removing it). |
|
@NetanelBasal I've updated the readme can you have a look and tell me if it's ok or not ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When you use the withCache() function in a HttpClient method, it needs to be assigned to the context option. How do you add something else to the HttpRequest context ?
Issue Number: #42
What is the new behavior?
Add a second argument to
withCachefunction to pass an optional existingHttpContextreturned from another function (similar towithCache).If the existing
HttpContexthas been provided, the function will use it; otherwise, the function will create a newHttpContext.Does this PR introduce a breaking change?
Other information