Enable leader election by default #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
I think it would be cleaner to have the flag default to true and remove all references to enabling leader election from manifests. But I'm happy with merging either.
kubernetes-ingress/cmd/nginx-ingress/main.go
Lines 104 to 105 in 07eb78a
|
That sounds better thanks @Dean-Coakley , I'll do the changes |
Rulox
force-pushed
the
leader-election-default
branch
from
4751236
to
ff2923f
Compare
Dean-Coakley
approved these changes
Jun 8, 2020
LorcanMcVeigh
approved these changes
Jun 8, 2020
Rulox
changed the title
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
With the new feature in #973, it is required to have leader election to avoid multiple replicas to try to update the VS/VSR status.
When the KIC is deployed using Helm,
leaderElectionis enabled by default. With this change, we do the same when the users deploy the KIC manually deploying the manifests.