Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Add permissions for gcr login to base image build (#5860) #5862

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jun 26, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested a review from a team as a code owner June 26, 2024 08:24
@oseoin oseoin changed the base branch from main to release-3.6 June 26, 2024 08:24
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 26, 2024
@oseoin oseoin enabled auto-merge (squash) June 26, 2024 08:27
@oseoin oseoin merged commit b475ea6 into release-3.6 Jun 26, 2024
65 checks passed
@oseoin oseoin deleted the cherry-pick-image-build-fix branch June 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

5 participants