Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP: allow waf users to build without dos repo access #5043

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 7, 2024

Proposed changes

cherry-pick (#5041)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 7, 2024 11:45
@pdabelf5 pdabelf5 changed the title allow waf users to build without dos repo access (#5041) CP: allow waf users to build without dos repo access Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63ac31a) 52.11% compared to head (b0ee57c) 52.13%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.4    #5043      +/-   ##
===============================================
+ Coverage        52.11%   52.13%   +0.01%     
===============================================
  Files               60       60              
  Lines            17368    17368              
===============================================
+ Hits              9052     9054       +2     
  Misses            8000     8000              
+ Partials           316      314       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 760d891 into release-3.4 Feb 9, 2024
67 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-dos branch February 9, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants