Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue [#4679]: Incorrect default value for main-template-path and… #4698

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

opencmit2
Copy link
Contributor

@opencmit2 opencmit2 commented Nov 23, 2023

… virtualserver-template-path flags

Proposed changes

Fix issue [#4679]

Improved documentation by resolving an issue with inaccurate default values for the main-template-path and virtualserver-template-path flags.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

…path and virtualserver-template-path flags

Signed-off-by: JustinWang <[email protected]>
@opencmit2 opencmit2 requested review from a team as code owners November 23, 2023 08:08
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 23, 2023
@opencmit2 opencmit2 closed this Nov 23, 2023
@opencmit2 opencmit2 reopened this Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6533296) 52.06% compared to head (b4dc824) 52.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4698   +/-   ##
=======================================
  Coverage   52.06%   52.06%           
=======================================
  Files          59       59           
  Lines       17033    17033           
=======================================
  Hits         8869     8869           
  Misses       7864     7864           
  Partials      300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjngx jjngx merged commit 4dc2d33 into nginxinc:main Nov 27, 2023
62 checks passed
@opencmit2 opencmit2 deleted the doc_fix_#4679 branch December 19, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wrong default value for main-template-path and virtualserver-template-path flag in the docs
4 participants