Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update example test certs #4587

Merged
merged 1 commit into from
Nov 1, 2023
Merged

update example test certs #4587

merged 1 commit into from
Nov 1, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 31, 2023 •
edited
Loading

Proposed changes

  • update example test certs as the existing ones expired
message: "Hello <IP_ADDRESS>"

PASSED

========== 1 passed, 490 deselected, 32 warnings in 143.98s (0:02:23) ==========

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner October 31, 2023 15:38
@github-actions github-actions bot added the tests Pull requests that update tests label Oct 31, 2023
@vepatel vepatel linked an issue Oct 31, 2023 that may be closed by this pull request
Update certificates used by grpc automated tests #4588
Closed
@vepatel vepatel requested a review from lucacome October 31, 2023 18:24
@vepatel vepatel merged commit 6b76c9d into release-3.3 Nov 1, 2023
53 of 56 checks passed
@vepatel vepatel deleted the tests/update-certs branch November 1, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update certificates used by grpc automated tests
3 participants
@vepatel @lucacome @jjngx