Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single CRDs files #4428

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add single CRDs files #4428

merged 2 commits into from
Oct 16, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

Second part of #4287

Moves the CRDs into a standard location config/crd/bases.
Adds kustomize to create a single CRDs file and single files CRDs for NAP WAF and NAP DoS.

@lucacome lucacome requested a review from a team as a code owner September 27, 2023 01:12
@lucacome lucacome self-assigned this Sep 27, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Sep 27, 2023
@github-actions github-actions bot added the tests Pull requests that update tests label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4428 (7165cb6) into main (f6deac5) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 7165cb6 differs from pull request most recent head 1df57b7. Consider uploading reports for the commit 1df57b7 to get more accurate results

@@            Coverage Diff             @@
##             main    #4428      +/-   ##
==========================================
- Coverage   51.96%   51.95%   -0.02%     
==========================================
  Files          59       59              
  Lines       16965    16956       -9     
==========================================
- Hits         8816     8809       -7     
+ Misses       7852     7850       -2     
  Partials      297      297              

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome force-pushed the chore/generate-crds branch 2 times, most recently from 36ab1f0 to 8ac58eb Compare September 27, 2023 02:08
@danielnginx danielnginx linked an issue Sep 27, 2023 that may be closed by this pull request
@jjngx jjngx requested review from shaun-nx, vepatel, haywoodsh and a team October 10, 2023 14:27
@lucacome lucacome enabled auto-merge (squash) October 16, 2023 15:22
@lucacome lucacome merged commit 5efe0f6 into main Oct 16, 2023
20 checks passed
@lucacome lucacome deleted the chore/generate-crds branch October 16, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add single CRDs files
4 participants