Refactor config writing

[feifeiiiiiiiiiii]

Signed-off-by: qinpengfei [email protected]

Proposed changes

Refactor write file code, reduce redundant code

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto master
• I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

[pleshakov]

Thanks for the PR. I left a few suggestions.

Also, could you possibly use createFileAndWrite in

kubernetes-ingress/internal/nginx/nginx.go

Line 230 in baf72e2

func (nginx *Controller) AddOrUpdateDHParam(dhparam string) (string, error) {

?

[pleshakov]

It is better to add more context to the log message:

glog.Fatalf("Failed to write NGINX conf: %v", err)

Additionally, I don't see why we need to use err.Error()) instead of just err

[feifeiiiiiiiiiii]

@pleshakov ok I will modify in accordance with you suggest

[pleshakov]

Similar to the main NGINX conf, better to add more context to the error message: "Failed to write version config: %v"

[pleshakov]

Thanks for addressing the suggestions!

Could you possibly address 2 additional suggestions and then rebase against the master?

[feifeiiiiiiiiiii]

@pleshakov modify and rebase done, but I not sure rebase is right, pls check

[pleshakov]

@feifeiiiiiiiiiii looks good, thank you! the rebase went well

Please squash your commits into a single one rebasing one more time, and we'd be happy merge it.

[feifeiiiiiiiiiii]

@pleshakov squash commits into a single commit has done, pls check