Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error handling #3936

Merged
merged 8 commits into from
May 31, 2023
Merged

Update error handling #3936

merged 8 commits into from
May 31, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented May 24, 2023

Proposed changes

This PR updates error handling in the validation package.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner May 24, 2023 14:52
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #3936 (af53ba5) into main (1ae8a55) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3936      +/-   ##
==========================================
- Coverage   51.81%   51.81%   -0.01%     
==========================================
  Files          59       59              
  Lines       16697    16697              
==========================================
- Hits         8652     8651       -1     
  Misses       7747     7747              
- Partials      298      299       +1     
Impacted Files Coverage Δ
pkg/apis/dos/validation/dos.go 97.27% <100.00%> (+2.72%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx requested a review from a team May 26, 2023 13:58
@jjngx jjngx requested a review from a team May 31, 2023 09:43
@jjngx jjngx merged commit 22c165b into main May 31, 2023
63 checks passed
@jjngx jjngx deleted the chore/validators branch May 31, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants