Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Mergeable Types misspelling and optimize blacklists #268

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

diazjf
Copy link

@diazjf diazjf commented Apr 11, 2018

Corrects incorrect spelling of 'mergeable' in different locations. Also optimizes filtering and merging functions by converting the blacklists to maps instead of arrays.

Fixes #269

@diazjf
Copy link
Author

diazjf commented Apr 11, 2018

@pleshakov I found a type when going over the code again. Also optimized the filtering and merging functions.

@diazjf diazjf force-pushed the correct-spelling branch 6 times, most recently from e4afe8f to 058c5ee Compare April 11, 2018 05:22
Corrects incorrect spelling of 'mergeable' in different locations.
Also optimizes filtering and merging functions by converting the
blacklists to maps instead of arrays.

Fixes nginxinc#269
@pleshakov pleshakov merged commit 203b36a into nginxinc:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants