Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.0 #2599

Merged
merged 11 commits into from
Apr 12, 2022
Merged

Release 2.2.0 #2599

merged 11 commits into from
Apr 12, 2022

Conversation

lucacome
Copy link
Member

Updates docs for 2.2.0

@lucacome lucacome requested review from a user April 12, 2022 05:50
@lucacome lucacome self-assigned this Apr 12, 2022
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #2599 (34b6e6e) into main (cc942f5) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
- Coverage   53.46%   53.43%   -0.03%     
==========================================
  Files          52       52              
  Lines       14696    14696              
==========================================
- Hits         7857     7853       -4     
- Misses       6579     6581       +2     
- Partials      260      262       +2     
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 6.86% <0.00%> (ø)
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

docs/content/releases.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
* [2576](https://github.com/nginxinc/kubernetes-ingress/pull/2576) Add support for IPv6.
* [2572](https://github.com/nginxinc/kubernetes-ingress/pull/2572) Automate provisioning of Certificate resources for VirtualServer resources using cert-manager.

ENHANCEMENTS:
Copy link
Collaborator

@brianehlert brianehlert Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or does this section feel light?
This all appears to be recent work, I could have sworn there was more.
This should go back to 2.1 - not just 2.1.2


12 Apr 2022

FEATURES:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecation of 'preview' should be repeated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in the CHANGES, that's where we usually have changes to the behavior of the IC. Is that enugh?

* [2479](https://github.com/nginxinc/kubernetes-ingress/pull/2479) Add cli argument to configure NGINX App Protect log level.
* [2455](https://github.com/nginxinc/kubernetes-ingress/pull/2455) Increase memory available for NGINX App Protect xml parser.

CHANGES:
Copy link
Collaborator

@brianehlert brianehlert Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That list is split between enhancements and features

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And helm chart

@lucacome lucacome marked this pull request as ready for review April 12, 2022 16:08
lucacome and others added 2 commits April 12, 2022 09:17
Co-authored-by: Brian Ehlert <[email protected]>
docs/content/releases.md Outdated Show resolved Hide resolved
docs/content/releases.md Outdated Show resolved Hide resolved
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

CHANGELOG.md Outdated Show resolved Hide resolved
@lucacome lucacome merged commit 47cea15 into main Apr 12, 2022
@lucacome lucacome deleted the chore/release-2.2.0 branch April 12, 2022 18:29
lucacome added a commit that referenced this pull request Apr 12, 2022
Co-authored-by: Ciara Stacke <[email protected]>
Co-authored-by: Brian Ehlert <[email protected]>
Co-authored-by: Jodie Putrino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants