Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace in default Make variables #2242

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Dec 6, 2021

Proposed changes

There is whitespace at the end of some of the default Make variables including TARGET ?= local because it is including the whitespace between the var and the comment on the same line. This means that make build is not doing anything without explicitly passing in the TARGET, e.g.make build TARGET=local. This commit removes the whitespace and returns the previous behaviour.

Current behaviour:

~/workspace/github/nginxinc/kubernetes-ingress master > make build
Docker version 20.10.10, build b485636

New behaviour:

~/workspace/github/nginxinc/kubernetes-ingress chore/fix-makefile-whitespace > make build
Docker version 20.10.10, build b485636
go version go1.17.1 darwin/amd64
CGO_ENABLED=0 GO111MODULE=on GOOS=linux go build -trimpath -ldflags "-s -w -X main.version=v2.0.3-SNAPSHOT-b90d4e7 -X main.commit=b90d4e733e1a799b2e16105ad07a6e9ee9a3e989 -X main.date=2021-12-06T12:29:23Z" -o nginx-ingress github.com/nginxinc/kubernetes-ingress/cmd/nginx-ingress

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug chore Pull requests for routine tasks labels Dec 6, 2021
@ciarams87 ciarams87 merged commit cbcb35d into master Dec 6, 2021
@ciarams87 ciarams87 deleted the chore/fix-makefile-whitespace branch December 6, 2021 18:05
@lucacome lucacome removed the bug An issue reporting a potential bug label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants