Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind app-protect from -preview-policies #2237

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

galitskiy
Copy link
Contributor

@galitskiy galitskiy commented Dec 2, 2021

Proposed changes

Unbind app-protect from -preview-policies.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@galitskiy galitskiy marked this pull request as ready for review December 2, 2021 15:33
@galitskiy galitskiy marked this pull request as draft December 2, 2021 15:40
@galitskiy galitskiy marked this pull request as ready for review December 2, 2021 20:41
@nginx-bot nginx-bot force-pushed the ap-remove-preview branch 7 times, most recently from 099a947 to 76b4c05 Compare December 7, 2021 17:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #2237 (49fda13) into master (cb8a7f1) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 49fda13 differs from pull request most recent head 4e47507. Consider uploading reports for the commit 4e47507 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2237      +/-   ##
==========================================
- Coverage   53.41%   53.35%   -0.06%     
==========================================
  Files          43       43              
  Lines       13413    13409       -4     
==========================================
- Hits         7164     7154      -10     
- Misses       6020     6024       +4     
- Partials      229      231       +2     
Impacted Files Coverage Δ
pkg/apis/configuration/validation/policy.go 95.39% <ø> (-0.05%) ⬇️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/k8s/configuration.go 95.65% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8a7f1...4e47507. Read the comment docs.

@nginx-bot nginx-bot force-pushed the ap-remove-preview branch 3 times, most recently from e71a5c2 to 886f517 Compare December 9, 2021 06:09
@nginx-bot nginx-bot force-pushed the ap-remove-preview branch 2 times, most recently from 49fda13 to 6dc45fe Compare December 10, 2021 16:20
@ciarams87 ciarams87 merged commit d954961 into nginxinc:master Dec 10, 2021
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants