Add option to download IC binary #2107
Conversation
lucacome
commented
Oct 19, 2021
lucacome
commented
- Added option to extract the binary from the Docker image
- Updated docs
- Small fixes to docs
lucacome
requested review from
ciarams87,
soneillf5 and
pleshakov
and removed request for
a team
github-actions
bot
added
documentation
|
|
||
| else | ||
| # we're on master or a branch, try to download the latest edge and see if sha matches | ||
| docker pull nginx/nginx-ingress:${docker_tag} >/dev/null 2>&1 |
There was a problem hiding this comment.
do we rebuild the edge images on every commit in the master or we optimize (for example, when no code changes were in the commit?)? if latter is the case, then we might not have an image that matches the commit
There was a problem hiding this comment.
We rebuild the images for every change except for docs and examples. In that case, you're right, it won't be possible to download the binary. Unfortunately, I don't see a workaround for this unless we want to always use the latest available binary, but I think that could cause more issues.
Similarly, if somebody is on an old commit, there's no way to get the corresponding edge image that was built in the past (unless we start tagging the image with the sha).
There was a problem hiding this comment.
if this can cause problems, perhaps we shall only support downloading for release tags then?
There was a problem hiding this comment.
if it's not the latest commit or a tag it will print this message:
unable to build with TARGET=download, this function is only available when building from a git tag or from the latest commit matching the edge image
do you think it's not enough?
There was a problem hiding this comment.
do you it's not enough?
yeah, I think it is enough
