AP: fix watch-namespace for NAP resources #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-bot
force-pushed
the
ap-fix-watch-namespace
branch
12 times, most recently
from
b6a4874
to
e8780e0
Compare
nginx-bot
force-pushed
the
ap-fix-watch-namespace
branch
9 times, most recently
from
ed5b890
to
0e8c7bf
Compare
nginx-bot
force-pushed
the
ap-fix-watch-namespace
branch
from
4590793
to
34c16bb
Compare
vepatel
approved these changes
Oct 27, 2021
pleshakov
approved these changes
Oct 28, 2021
rafwegv
force-pushed
the
ap-fix-watch-namespace
branch
from
c7b682d
to
ce5218c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change dynamic informer to filtered dynamic informer so that the -watch-namespace parameter can be enforced.
Checklist
Before creating a PR, run through this checklist and mark each as complete.