Add externl references to NAP #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafwegv
added
the
enhancement
pleshakov
reviewed
Aug 18, 2020
| If the references are not available during ingress controller startup the pod will fail to startup. In case the resources are not available during a reload, the reload will fail, and ingress controller will process traffic with the previous correct configuration. | ||
|
|
||
| ### Check the HTTP response time to resources used in App Protect policy external references. |
There was a problem hiding this comment.
This should be moved under the Troubleshooting Methods section, as it is a troubleshooting method.
I suggest two small enhancements:
- For brevity, renaming it to "Check the Availability of APPolicy External References"
- Adding the disclaimer like this:
This method only applies if you're using external references in NGINX App Protect policies.
pleshakov
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds external references feature to ingress controller + App Protect, and also adds some content to troubleshooting docs.
Checklist
Before creating a PR, run through this checklist and mark each as complete.