Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VirtualServer custom template support #1036

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Add VirtualServer custom template support #1036

merged 2 commits into from
Jul 7, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Allow using a custom template for VirtualServer resources via configmap key virtualserver-template.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jul 6, 2020
@Dean-Coakley Dean-Coakley self-assigned this Jul 6, 2020
pleshakov
pleshakov reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley
the code looks good!
I left a few examples related suggestions.

examples-of-custom-resources/custom-templates/README.md Outdated Show resolved Hide resolved
examples/custom-templates/README.md Outdated Show resolved Hide resolved
pleshakov
pleshakov approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Rulox
Rulox approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dean-Coakley Dean-Coakley merged commit 46e0c06 into master Jul 7, 2020
@Dean-Coakley Dean-Coakley deleted the add-crd-custom-templates branch July 7, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dean-Coakley @pleshakov @Rulox