Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended splt_analysis parameter to allow up to 65535 values #191

Merged
merged 1 commit into from
May 10, 2024

Conversation

drnpkr
Copy link
Member

@drnpkr drnpkr commented Dec 20, 2023

Extend splt_analysis parameter to allow up to 65535 values

This PR was recreated as a new one due to branch rename that effectively closed the previous PR.

Description

  • Updated the setter for the splt_analysis parameter to allow values up to 65535 instead of the previous limit of 255.
  • Added a warning message for values above 255 due to potential performance implications.
  • Updated the test_splt_analysis_parameter method to reflect the extended valid range for splt_analysis.

This change allows users to specify a larger number of packet dissections for NFStream, enabling more detailed analysis where needed, while also informing them of potential performance impacts.

Type of change

Please delete options that are not relevant.

  • Enhancement
  • This change requires a documentation update

How Has This Been Tested?

  • Tested via the included test.py script (also updated it to reflect the enhancement).
  • Tested it via running in both live and offline modes.

Test Configuration:

  • OS version: MacOS 12.6.7 (21G651)
  • Python version: 3.11.4
  • Hardware: MacBook Air Early 2015

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings It does, however, it is rather a notification for the user.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@aouinizied aouinizied merged commit 29e7e60 into nfstream:master May 10, 2024
34 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants