scrambles for older years #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrcaseb I think this is ready except for the test failing because it changes the output and no longer matches expected output (eg scramble, rush, pass etc change on some plays) |
mrcaseb
requested changes
Jun 14, 2024
|
I can update test expectation but will be out of town until Sunday |
because some scrambles changed with this PR
mrcaseb
previously approved these changes
Jun 17, 2024
|
Seems like MacOS isn't happy with the new expectation. I will review later. Also I introduced some new "global variable" warnings that could be fixed in this PR as well |
if unix/windows fail now, we have to round to 3 significant digits instead of 4
|
Tests still failing? |
|
|
|
Still fails even with a pretty lenient tolerance. I am confused. It's like it's ignoring the tolerance param. |
it wasn't saved correctly anyways as the initial "round_double_to_digits" converted all double variables to character and I saved this as expectation
also round to 3 significant digits because tests failed on Mac in the 4th digit
mrcaseb
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress. The older years of data are a mess in the NFL pbp