Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows compiling with native tools and clang, macos catalina compiling, added travis ci build tests #611

Merged
merged 9 commits into from
Jul 11, 2020

Conversation

gelotus
Copy link
Contributor

@gelotus gelotus commented Jul 7, 2020

Compiles fine in windows with cmake, with clang, clang-cl and cl. Compiles fine in linux with autotools, cmake, clang and gcc. Compiles fine in macos catalina with cmake, autotools and clang. Added travis ci build test of these. I think windows mingw is broken, at least with 8.1 that travis ships. There is no 64bit usblib and i was unable to tell wingw to take 32bit libs when compiles, but i've not lost much time on this frankly, since msvc build just works. Maybe the next move will be to drop autotools and use only cmake, and migrate to libusb1 with libusb-compat wrapper. That's all for now.

libnfc/CMakeLists.txt Outdated Show resolved Hide resolved
libnfc/CMakeLists.txt Outdated Show resolved Hide resolved
@doegox doegox merged commit cc4311a into nfc-tools:master Jul 11, 2020
@doegox
Copy link
Member

doegox commented Jul 11, 2020

very impressive, including Travis, thanks a lot !

@gelotus
Copy link
Contributor Author

gelotus commented Jul 13, 2020

You are welcome. I think you can close pr #418 #457 and #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants