Correcting a bug introduced in fbdbe6eff32ae5c01a6ea707a4e908c0cb1a4ebe #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quantum-x I think your commit introduced the bug, if you can have a look 😃 |
|
Unless I'm mistaken, my commit was OK, it looks like it was the merge that caused the issue? |
|
@quantum-x ah, maybe! I don't have access to your link though. Sorry about that :) |
|
@nmalzieu please confirm this is still an issue and provide test instructions to demonstrate problem - i have been unable to reproduce any block writing error. thanks! |
|
I believe this is now fixed. Thanks @nmalzieu for the initial report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is not clear but the fix is actually really simple
In fbdbe6e#diff-6e1237eedf36b29193c30b63cf243259R449 a new check was added line 449 before printing an authentication error but the closing bracket
}was not added.The result is
is_first_blockis not closed and the rest of the code is not executed so only 1st blocks of each sector was written!By checking the files directly it's really simple to see.