Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number of blocks written. Fix number of written blocks reported. #389

Merged
merged 2 commits into from
Mar 1, 2017
Merged

Fix number of blocks written. Fix number of written blocks reported. #389

merged 2 commits into from
Mar 1, 2017

Conversation

AdamLaurie
Copy link
Member

No description provided.

@doegox
Copy link
Member

doegox commented Feb 17, 2017

Hi Adam
Thanks for spotting this issue.
But I believe the problem came from changing the boundary computation in ed62b01.
WRITE can only be done by page, not by block, so there is no point trying to go back & forth (/4*4)
So I reverted it partly, see b86b7ef.
Does it solve the issue?

@doegox doegox merged commit e119296 into nfc-tools:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AdamLaurie @doegox