Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed size error when creating dump files of mfclassic #348

Closed
wants to merge 1 commit into from

Conversation

ricardojrdez
Copy link

When reading mifare classic cards, dump files were created of 4K size regardless the card type. Fix in line 689 solves this issue, creating a dump file of the same size than the card being dumped.

@doegox
Copy link
Member

doegox commented Feb 17, 2017

Thanks for spotting hardcoded size.
I cleaned the code in c5e8adc
Note that regarding the "fixed size error when creating dump files", your proposed change won't change anything as line 689 (now at https://github.com/nfc-tools/libnfc/blob/master/utils/nfc-mfclassic.c#L712) is only about erasing the buffer. Real size of written dump is defined at https://github.com/nfc-tools/libnfc/blob/master/utils/nfc-mfclassic.c#L742

I tried on MFC Mini / MFC 1k / MFC 4k / MFP 2k, all dump sizes seem ok now.

@doegox doegox closed this Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants