Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NEWS and README with links to md files #346

Closed
wants to merge 1 commit into from

Conversation

frankmorgner
Copy link
Contributor

NEWS and README are mandatory for autoconf. Fixes problem introduced in
b1a81b3

The current status can be checked here https://travis-ci.org/frankmorgner/vsmartcard/jobs/122279341#L2087

NEWS and README are mandatory for autoconf. Fixes problem introduced in
b1a81b3
@smortex
Copy link
Contributor

smortex commented Apr 11, 2016

Wouldn't it be wiser to add foreign to AM_INIT_AUTOMAKE?.

@frankmorgner
Copy link
Contributor Author

The foreign option tells Automake that this package will not follow the GNU Standards.

Seems to be an other way to solve the issue, but I'm not the one to decide...

@hiddewie
Copy link
Contributor

hiddewie commented May 1, 2016

I saw the build failure because of my commit(s). Sorry for not checking the makefile for changes.

@frankmorgner
Copy link
Contributor Author

No problem. Who is in charge for deciding the actual resolution? @neomilium @smortex @doegox ?

@doegox
Copy link
Member

doegox commented May 2, 2016

If @smortex solution works, I'm more in favor of it that creating phony files.

frankmorgner added a commit to frankmorgner/libnfc that referenced this pull request May 3, 2016
NEWS and README are mandatory for autoconf. Fixes problem introduced in
b1a81b3

closes nfc-tools/libnfc#346
fixes nfc-tools/libnfc#347
@frankmorgner
Copy link
Contributor Author

done and fixed in #349

@oliv3r
Copy link
Contributor

oliv3r commented Oct 21, 2016

The applied fix in #349 is insufficient as this still fails for cmake.

CMake Error at /usr/share/cmake-3.6/Modules/CPack.cmake:423 (message):
CPack package description file: "/home/oliver/dev/libnfc/README" could not
be found.

@frankmorgner how does @hiddewie compile libnfc? As both automake and cmake complain(ed) loudly ...

@frankmorgner
Copy link
Contributor Author

@oliv3r not quite true, autotools build just fine with #349 (i.e. current master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants