Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mifare Mini 0.3k #50

Merged
merged 3 commits into from
Nov 29, 2016
Merged

Add support for Mifare Mini 0.3k #50

merged 3 commits into from
Nov 29, 2016

Conversation

pi3rrot
Copy link
Contributor

@pi3rrot pi3rrot commented Nov 22, 2016

Mifare Mini is the same as Mifare Classic, the only difference is about the memory size (Sector number).
Instructions are the same.
Easy patch 👍

Copy link
Contributor

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

There a some minor issues that need to be fixed before it can be merged:

  • Two function declarations are missing from libfreefare.h;
  • The freefare.3 man page should include the new MIFARE_MINI constant in the enum.

@@ -194,6 +194,16 @@ int get_block_access_bits (FreefareTag tag, const MifareClassicBlockNumber blo
*/

bool
mifare_mini_taste (nfc_device *device, nfc_target target)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should be declared in libfreefare/freefare.h

@@ -237,6 +247,13 @@ _mifare_classic_tag_new (nfc_device *device, nfc_target target, int tag_type)
return tag;
}


FreefareTag
mifare_mini_tag_new (nfc_device *device, nfc_target target)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should be declared in libfreefare/freefare.h

@pi3rrot
Copy link
Contributor Author

pi3rrot commented Nov 22, 2016

It's done :)

@pi3rrot pi3rrot closed this Nov 22, 2016
@pi3rrot pi3rrot reopened this Nov 22, 2016
@pi3rrot pi3rrot closed this Nov 25, 2016
@pi3rrot pi3rrot reopened this Nov 25, 2016
@pi3rrot
Copy link
Contributor Author

pi3rrot commented Nov 25, 2016

Oups... sorry for disturbing the thread

Copy link
Contributor

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can another reviewer give feedback / merge this request ? Thanks!

@doegox
Copy link
Member

doegox commented Nov 29, 2016

Seems fine to me. Thanks for the patches @pi3rrot !

@doegox doegox merged commit d7c1aa6 into nfc-tools:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants