Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support of a new ATS for DESFire EV1 on JCOP3 #138

Merged
merged 1 commit into from
May 31, 2021

Conversation

AlexandreFenyo
Copy link
Contributor

Adding support of a new ATS sent by a DESFire EV1 applet found on a JCOP3 P60 chip.
I've split the check of the ATS length into two checks.

Adding support of a new ATS sent by a DESFire EV1 applet found on a JCOP3 P60 chip.
I've split the check of the ATS length into two checks.
Copy link
Contributor

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bothering @darconeous again in case he wants to step in.

For your information, you can rework a branch by amending it's commit and force-pushing to GitHub and any open PR will be updated accordingly. It makes it easier to follow the changes and avoids you the pain of juggling with PRs 😉

@AlexandreFenyo
Copy link
Contributor Author

Many thanks, I was wondering if it was possible to do it simpler !

@AlexandreFenyo
Copy link
Contributor Author

Hi, do I have anything for the pull to be done ?
Thanks,

@smortex smortex merged commit c2b0cfa into nfc-tools:master May 31, 2021
@smortex
Copy link
Contributor

smortex commented May 31, 2021

Since I have no way to test this for real, I would love to have feedback from other people. but I guess that if this break something, somebody will come here with a fix 😝

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants