support of a new ATS for DESFire EV1 on JCOP3 #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support of a new ATS sent by a DESFire EV1 applet found on a JCOP3 P60 chip. Changing the minimum ATS length because of this applet.
smortex
approved these changes
May 19, 2021
There was a problem hiding this comment.
LGTM, @darconeous has contributed the most recent change in this code regarding other JCOP cards and might want to review this?
I guess that reducing AtsLen is not an issue, but maybe we will want to split this into two checks, one for AtsLen >= 5 and one for AtsLen >= 4? Really not sure about this, I have been far far away from these NFS stuff for so many years… :-/
|
OK, I will create a new pull request splitting the code into two checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support of a new ATS sent by a DESFire EV1 applet found on a JCOP3 P60 chip.
Changing the minimum ATS length because of this applet.