Add support for JCOP cards with DESFire emulation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that long-term we may want to change how we are checking the ATS so that it isn't fragile to changes in the first four bytes of the ATS (which are changeable in DESFire EV2!). We may even want to consider removing the ATS check entirely, perhaps simply making sure that the ATS is there and having that be good enough. |
Some JCOP cards support native DESFire EV1/EV2 emulation, but the existing code was ignoring these cards because they didn't have the expected ATS prefix. This change updates `mifare_desfire_taste` to also return true for JCOP cards with DESFire support, allowing them to be used with libfreefare.
darconeous
force-pushed
the
desfire-jcop-support
branch
from
56b4126
to
889ec34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some JCOP cards (like this one) support native DESFire emulation, but the existing code was ignoring these cards because they didn't have the expected ATS prefix.
This change updates
mifare_desfire_tasteto also return true for JCOP cards with DESFire support, allowing them to be used with libfreefare.