Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Added examples/mifare-desfire-ev1-change-picc-key #119

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darconeous
Copy link
Member

Note: This commit is a work in progress and depends on pull-request #118.

This example demonstrates how to change the PICC key for a DESFire EV1 card, while also aiming to be a generally useful tool for locking/unlocking DESFire credentials.

@smortex
Copy link
Contributor

smortex commented Oct 29, 2019

Ah, this also include changes form #118. Maybe better keep each topic in a dedicated branch, and if you need both changes for working use a custom local branch where you merge both of them :-)

This look okay, but I have no more NFC devices left to try it… I have not been doing NFC for a few years.

I don't remember if I asked if you would be interested in gaining maintainership to libfreefare? I would still be around to help, but as I am mostly alone and not uing this anymore, it really does not makes sense the community rely on me for things to move on 😥

@darconeous
Copy link
Member Author

It currently depends on those changes. Once #118 is merged, then this one can be considered for merging. I really wish GitHub was better about making those things clear.

I'm happy to help with some maintenance, such as reviewing patches and such. That's about the extent of the amount of responsibility I'm ready to take on at the moment, but I may be willing to take on more later on. (On that topic, what is the state of the whole nfc-tools project? I notice that nfc-tools.org is dead. So is libnfc.org.)

@smortex
Copy link
Contributor

smortex commented Oct 29, 2019

I added you as a collaborator, unless I am wrong, I believe you can approve Pull Requests and merge approved Pull Requests. I guess #118 can be merged quickly, then rebasing this branch on top of master should update it properly and we will be able to sort it out in a timely fashion.

I was aware some websites where broken some times ago, it seems to be worse… Let's try to fix this in nfc-tools/libnfc#558.

Note: Work in progress.

This example demonstrates how to change the PICC key for
a DESFire EV1 card, while also aiming to be a generally useful
tool for locking/unlocking DESFire credentials.
@darconeous darconeous changed the title Added examples/mifare-desfire-ev1-change-picc-key [DRAFT] Added examples/mifare-desfire-ev1-change-picc-key Dec 11, 2019
@darconeous darconeous marked this pull request as draft April 13, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants