Added safety check len == 0 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darconeous
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Looks good, but I know @smortex loves unit tests. I personally wouldn't hold this change back for lack of one, but let's see what he thinks.
|
Oh yes, that was open for a long time. Never mind, the unit tests are not critical for this and the behavior was wrong. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #69, compiled with success, not tested. Would anyone test that it is working ?
P. S. Please check if my identation is correct, I set it to 4 spaces like it said in
HACKING.md.