-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wave): adding profile seqera_containers #1291
base: dev
Are you sure you want to change the base?
Conversation
|
nextflow.config
Outdated
@@ -248,6 +248,13 @@ profiles { | |||
shifter.enabled = false | |||
charliecloud.enabled = false | |||
} | |||
wave { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this should be called seqera-container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about community-containers
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you are right, though, because "Bio(containers)" is prefixed by the Bioconda community.
Co-authored-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to propagate the name change / other changes (eg. no docker
strategy) back to the template 👍🏻
apptainer.ociAutoPull = true | ||
singularity.ociAutoPull = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed otherwise it will cause the use of a docker container to be converted to singularity one ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also worth adding wave.build.conda.mambaImage = 'mambaorg/micromamba:1.5.8-lunar'
to prevent containers changes quietly when the base image will change on wave side
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).