Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename preprocess rnaseq #5959

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Rename preprocess rnaseq #5959

merged 8 commits into from
Jul 16, 2024

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Jul 10, 2024

Per extensive discussion in the nf-core Maintainers team, renaming the preprocess_rnaseq workflow (which I wrote, hopefully not used by anyone else yet), per new guidelines nf-core/website#2625.

Alternative is to copy instead to preserve any links to the old subworkflow, but it would leave a bit of a mess...

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@pinin4fjords pinin4fjords requested a review from a team as a code owner July 10, 2024 16:47
@pinin4fjords pinin4fjords requested review from vagkaratzas and removed request for a team July 10, 2024 16:47
@pinin4fjords pinin4fjords requested review from mashehu and removed request for vagkaratzas July 15, 2024 16:39
@pinin4fjords
Copy link
Member Author

Thanks @maxulysse !

@pinin4fjords pinin4fjords added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 81ed776 Jul 16, 2024
12 checks passed
@pinin4fjords pinin4fjords deleted the rename_preprocess_rnaseq branch July 16, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants