Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Severus #5951

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Add Severus #5951

merged 6 commits into from
Aug 15, 2024

Conversation

fellen31
Copy link
Contributor

Closes #5797

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@fellen31 fellen31 force-pushed the add-severus branch 3 times, most recently from 43e09ad to 6bed86b Compare July 10, 2024 11:26
@fellen31 fellen31 marked this pull request as ready for review July 10, 2024 11:40
@fellen31 fellen31 requested a review from a team as a code owner July 10, 2024 11:40
@fellen31 fellen31 requested review from Aratz and removed request for a team July 10, 2024 11:40
description: |
Groovy Map containing sample information
e.g. `[ id:'sample1', single_end:false ]`
- target_bam:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the tool also support cram inputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to something like target_input?
We really need a good word that covers bam and cram files...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I chose target_bam because the program argument is --target-bam. But I can change it to target_input & control_input.

@fellen31
Copy link
Contributor Author

Updated meta.yml to also include cram, csi and crai @matthdsm

description: |
Groovy Map containing sample information
e.g. `[ id:'sample1', single_end:false ]`
- target_bam:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to something like target_input?
We really need a good word that covers bam and cram files...

modules/nf-core/severus/meta.yml Show resolved Hide resolved
modules/nf-core/severus/meta.yml Outdated Show resolved Hide resolved
@fellen31 fellen31 added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@SPPearce SPPearce added this pull request to the merge queue Aug 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 15, 2024
@fellen31 fellen31 added this pull request to the merge queue Aug 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 15, 2024
@fellen31
Copy link
Contributor Author

The VCF contained a date, changed the snapshot to store the lines around it.

@fellen31 fellen31 added this pull request to the merge queue Aug 15, 2024
Merged via the queue into nf-core:master with commit e47767d Aug 15, 2024
12 checks passed
@fellen31 fellen31 deleted the add-severus branch August 15, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: Severus
3 participants