Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAST alignment statistics for MultiQC #5902

Merged
merged 12 commits into from
Jul 11, 2024

Conversation

charles-plessy
Copy link
Contributor

@charles-plessy charles-plessy commented Jul 2, 2024

This PR adds a multiqc output channel to the last/train, last/lastal and last/split modules. The new channel provides statistics in TSV format.

For last/lastal the MultiQC file contains some of the alignment parameters determined by this module. Their value is quickly retrieved by parsing a text file.

For last/lastal and last/split, the MultiQC file contains the total alignment length and percent similarity computed on the fly while the alignment is being performed.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I have to trust you that it works, but the code is nice and clean.

@charles-plessy
Copy link
Contributor Author

Yes it works !
image

@nictru nictru added this pull request to the merge queue Jul 11, 2024
Merged via the queue into nf-core:master with commit 882e20c Jul 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants