-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GMM-Demux #5892
Add GMM-Demux #5892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks quite good, great job! I like the input file solution you implemented. I know this module is annoying to implement, so thanks for putting in the work!
There are just two main issues that need addressing:
- inconsistencies regarding file names and input/output patterns
- rather unspecific tests
If anything is unclear don't hesitate to ask.
I've tried to adhere to the review conventions outlined here, I hope it's a helpful format.
The tool seems to work fine without specifying any of the optional outputs, can we just test that without the additional config? |
Currently the prefix is only used in the |
I added one simple test without nextflow.config, please let me know if it's correct |
…-demux merge new files
@@ -0,0 +1,105 @@ | |||
{ | |||
"Standard_Multiome - 10x mtx - Stub": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has -Stub
, and not the actual test output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran nf-core modules test gmmdemux --update
but didin't create a new snapshot, then deleted the file main.nf.test.snap
, but it didn't produce a new file, so I fixed the name from Stub to stub, is that right? I read that it was possible on Slack
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda