Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GMM-Demux #5892

Merged
merged 33 commits into from
Aug 8, 2024
Merged

Add GMM-Demux #5892

merged 33 commits into from
Aug 8, 2024

Conversation

mari-ga
Copy link
Contributor

@mari-ga mari-ga commented Jun 27, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mari-ga mari-ga requested a review from a team as a code owner June 27, 2024 15:43
@mari-ga mari-ga requested review from leoisl and removed request for a team June 27, 2024 15:43
@mari-ga mari-ga requested a review from tstoeriko June 27, 2024 15:55
Copy link
Contributor

@tstoeriko tstoeriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks quite good, great job! I like the input file solution you implemented. I know this module is annoying to implement, so thanks for putting in the work!

There are just two main issues that need addressing:

  • inconsistencies regarding file names and input/output patterns
  • rather unspecific tests

If anything is unclear don't hesitate to ask.
I've tried to adhere to the review conventions outlined here, I hope it's a helpful format.

modules/nf-core/gmmdemux/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gmmdemux/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gmmdemux/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gmmdemux/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gmmdemux/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/gmmdemux/tests/main.nf.test Show resolved Hide resolved
modules/nf-core/gmmdemux/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gmmdemux/tests/nextflow.config Outdated Show resolved Hide resolved
modules/nf-core/gmmdemux/main.nf Show resolved Hide resolved
modules/nf-core/gmmdemux/main.nf Outdated Show resolved Hide resolved
@mari-ga mari-ga requested a review from SPPearce August 1, 2024 10:12
@SPPearce
Copy link
Contributor

SPPearce commented Aug 1, 2024

The tool seems to work fine without specifying any of the optional outputs, can we just test that without the additional config?

@SPPearce
Copy link
Contributor

SPPearce commented Aug 1, 2024

Currently the prefix is only used in the summary_report_${prefix}.txt file (which should probably be ${prefix}_summary_report.txt).
Do we want to rename the output files with ${prefix}?

@mari-ga
Copy link
Contributor Author

mari-ga commented Aug 1, 2024

I added one simple test without nextflow.config, please let me know if it's correct

@mari-ga mari-ga requested a review from SPPearce August 5, 2024 07:19
@@ -0,0 +1,105 @@
{
"Standard_Multiome - 10x mtx - Stub": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still has -Stub, and not the actual test output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran nf-core modules test gmmdemux --update but didin't create a new snapshot, then deleted the file main.nf.test.snap , but it didn't produce a new file, so I fixed the name from Stub to stub, is that right? I read that it was possible on Slack

@mari-ga mari-ga added this pull request to the merge queue Aug 8, 2024
Merged via the queue into nf-core:master with commit 959c82d Aug 8, 2024
12 checks passed
@mari-ga mari-ga deleted the gmm-demux branch August 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants