Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new module: yte #5886

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

new module: yte #5886

wants to merge 2 commits into from

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Jun 26, 2024 •
edited
Loading

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

I still need to check how params are handed to yte. Hence this is a draft PR until that is clarified. I will also add tests then.

@famosab famosab added new module Adding a new module draft labels Jun 26, 2024
@famosab famosab self-assigned this Jun 26, 2024
SPPearce
SPPearce reviewed Jun 27, 2024
View reviewed changes
modules/nf-core/yte/tests/main.nf.test
tag "modules_nfcore"
tag "yte"

test("yaml - no_template") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is confusing to me, as it seems that you are passing a template...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file that is usally used as input is a template yaml. I have not created one yet so I am just passing a simple yaml file. (The file ending stays the same) I wanted to make that visible in the test name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest a comment to that effect then.

@famosab
Copy link
Contributor Author

famosab commented Aug 2, 2024

Yte is being extended to allow the use of templates via the CL: yte-template-engine/yte#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@famosab famosab

Labels
draft new module Adding a new module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@famosab @SPPearce