Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate DRY #5768

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Renovate DRY #5768

wants to merge 3 commits into from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Jun 6, 2024

Removes all the stuff that's duplicated at https://github.com/nf-core/ops/blob/main/.github/renovate/default.json5

Even if you automerge PRs, you are likely to still get notification noise - one when the PR is created and another when it is merged. For this reason we recommend you consider setting automergeType=branch which will mean:

  • Renovate first creates a branch and no PR
  • If tests pass, Renovate pushes a commit directly to the base branch without PR
  • If tests fail, Renovate raises a PR for you to review

Add the renovate/** branch to your testing workflow files, or Renovate will not work properly with the automergeType=branch setting.

@edmundmiller edmundmiller self-assigned this Jun 6, 2024
@edmundmiller edmundmiller changed the title Renovate noise Renovate DRY Jun 6, 2024
@edmundmiller edmundmiller requested a review from a team as a code owner June 6, 2024 19:15
@mashehu
Copy link
Contributor

mashehu commented Jun 7, 2024

We don't allow direct pushes to the dev branch, so not sure if that automerge here will work.

@edmundmiller
Copy link
Contributor Author

I think we can all renovate both to by pass that(according to their docs)

@edmundmiller
Copy link
Contributor Author

image
This is what we'd need to enable(didn't save the config)

@edmundmiller edmundmiller mentioned this pull request Jun 7, 2024
@SPPearce
Copy link
Contributor

So are we planning on changing the settings?

@edmundmiller
Copy link
Contributor Author

Unless anyone states otherwise, but I'd need someone else to at-least approve the PR.

@mirpedrol
Copy link
Member

Where are we setting automergeType=branch?

@mashehu
Copy link
Contributor

mashehu commented Jun 13, 2024

I personally don't like an automerge for version updates. I would still prefer a PR per update even if we always accept them. But it allows a bit better oversight what has been changed.

@SPPearce
Copy link
Contributor

If it can stop spamming PRs like #5757 that'd be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants