-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle empty files #5720
Handle empty files #5720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a way to avoid sending falco empty fastqs. Modifying falco module itself looked straighforward to me but it seems I was not aware that it will cause other troubles as stated by the reviewer: #5769 (review), I will close my PR then.
Why is the read group parsing being removed? |
This is a mistake on my part. I thought the read group parsing would download a local copy of the FASTQ file when the file was in cloud storage. Thus, I decided to remove it. However, I see now that it is a buffered Input stream and the file is not downloaded. I will add the read group parsing back in. |
This should be ready to go now. I had trouble with the nf-test for BCL Convert. The problem was that the test data file permissions were too restrictive. Because the GitHub action is self hosted with rootless docker, the test is executed as the host user and it could not read the test data when the volume is mounted. The fix was to change the test data file permissions to 775. It was an easy fix but it took me awhile to figure out what was going wrong. I found this explanation helpful https://joeeey.com/blog/rootless-docker-avoiding-common-caveats/#storage-fixes. |
@matthdsm , @glichtenstein, are you happy with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
This PR fixes #5612
This PR also handles empty FASTQ files by including a empty fastq emit channel