Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No r version in tximport snapshots #5097

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

pinin4fjords
Copy link
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@pinin4fjords pinin4fjords requested a review from a team as a code owner March 11, 2024 13:30
@pinin4fjords pinin4fjords requested review from kpadm and removed request for a team March 11, 2024 13:30
@pinin4fjords
Copy link
Member Author

Thanks @adamrtalbot

@pinin4fjords pinin4fjords added this pull request to the merge queue Mar 11, 2024
Merged via the queue into master with commit c275c3b Mar 11, 2024
11 checks passed
@pinin4fjords pinin4fjords deleted the tximport_no_r_version branch March 11, 2024 15:26
@adamrtalbot
Copy link
Contributor

From @pinin4fjords:

(should make versions file reproducible across Docker/ Conda in the pseudoalignment subworkflow snapshots)

jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants