Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fix for LD_LIBRARY_PATH in singularity mode #4347

Merged
merged 10 commits into from
Nov 16, 2023
Merged

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Nov 16, 2023

We had severe problems getting Nextflow to run the Sentieon-images from https://depot.galaxyproject.org/singularity/sentieon%3A202308--h43eeafb_0
in singularity-mode.

Don Freed of Sentieon identified the problem, and Pontus found the fix presented in this PR.

I've tested the fix with Sentieon and I can now run the following test:

nextflow run main.nf -profile test_cache,software_license,<env> --sentieon_extension --aligner sentieon-bwamem --outdir results

with <env> set to docker, singularity and conda.

If the solution is satisfactory, then I'll implement it in the other Sentieon-modules.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Copy link
Contributor

@pontus pontus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asp8200
Copy link
Contributor Author

asp8200 commented Nov 16, 2023

CI-tests failing but I think that is all due to API rate limit exceeded.

@asp8200 asp8200 marked this pull request as ready for review November 16, 2023 17:10
@DonFreed
Copy link

This seems OK to me.

I would prefer that this is fixed in the container (which seems to require a change in the biocontainers build process). However, I understand that might not be feasible. This seems like an acceptable workaround to get this working quickly.

@asp8200 asp8200 added this pull request to the merge queue Nov 16, 2023
Merged via the queue into master with commit 9e16ade Nov 16, 2023
10 checks passed
@asp8200 asp8200 deleted the bioconda_sentieon branch November 16, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants