Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fastp #3419

Merged
merged 4 commits into from
May 15, 2023
Merged

Bump fastp #3419

merged 4 commits into from
May 15, 2023

Conversation

matthdsm
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@matthdsm matthdsm added this pull request to the merge queue May 15, 2023
@mashehu mashehu removed this pull request from the merge queue due to a manual request May 15, 2023
@mashehu
Copy link
Contributor

mashehu commented May 15, 2023

Sorry, the test with the subworkflows need to be fixed before this can be added to the merge queue

@matthdsm
Copy link
Contributor Author

Everything passed except for conda, which is known to fail from time to time?

@mashehu
Copy link
Contributor

mashehu commented May 15, 2023

sorry, you are correct

@mashehu mashehu added this pull request to the merge queue May 15, 2023
Merged via the queue into master with commit 37a98dd May 15, 2023
@maxulysse maxulysse deleted the bump/fastp branch May 23, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants