Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add new issue template for creating new module #283

Merged
merged 3 commits into from
Mar 19, 2021
Merged

feature: add new issue template for creating new module #283

merged 3 commits into from
Mar 19, 2021

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@drpatelh
Copy link
Member

Nice! Thanks @maxulysse 😎 Just need to fix the markdown lint!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member Author

Nice! Thanks @maxulysse sunglasses Just need to fix the markdown lint!

Did not realize that my editor changed to TOC

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌 just a few typos

.github/ISSUE_TEMPLATE/new_module.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/new_module.md Outdated Show resolved Hide resolved
@maxulysse maxulysse merged commit e61f400 into nf-core:master Mar 19, 2021
@maxulysse maxulysse deleted the master_new_module branch March 19, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants