-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tool: biobambam/bamsormadup #1478
Conversation
I'm trying to run the tests locally, but keep running into errors with both docker and conda. Some help would be much appreciated |
I ran it with manually with conda and got the error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall pretty good, just a few requests/suggestions
Co-authored-by: James A. Fellows Yates <[email protected]>
Awesome, thanks for the review. I'll get to it right away! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops something went funky in last review and missed a bunch of comments..
Also tests were failing previously
$args \\ | ||
I=$bam \\ | ||
O=${prefix}.bam \\ | ||
M=${prefix}.metrics.txt \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove metrics
, file naming should be up to the pipeline developer 1
Footnotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would you suggest differentiating the filename? Or do you mean remove M=xxx
and moving it to $args
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just I mean just specify as {prefix}.txt
, unless the tool can also produce other .txt
files? Otherwise .txt
should be enough to differentiate - and a pipeline developer can add metrics
themselves if they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allright, thanks. This is resolved than.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you reverted back to metrics
, is that required by the tool in the end?
- add (optional) reference input - add bam index ouput - add cram output option - make metrics output: more general
Is there a common way to check the args for errors? Also, is there a way to set the output extension based on a (possibly undefined) arg ( |
It's generally OK to add some checks in the and like wise for the variable extension, you are welcome to write a internal conditional variable to adust this |
Most comments are fixed! Now we just need to get the tests to work... |
Co-authored-by: James A. Fellows Yates <[email protected]>
For the failng tests, have you tried running locally? |
Yeah, but I keep having some issues with the
|
This is an unfortunate misdirection , you need to check the actual working directory or the .nexflow.log of the test to see what the error is (I hate python traceback sometimes ;) ) . I suspect the process is failing too early so it doesn't generate the versions.yml and but for whatever reason that specific check is the one that makes the largest error... |
Ok, looks like a syntax error, altough I'm not really sure what's wrong...
|
The other option is to pick other BAM files from the nf-core test/datasets and see if the ywork! There are quite a few now. |
I've tried using |
The issue must be somewhere in the module, because when I update |
Downgrading the version of |
…bammarkduplicates2
@matthdsm if you go into the work directory of the process (after a failing test), and try manually running |
I can't run any of the commands locally, the conda recipe isn't built for ARM, so not available on my computer |
Ah I see... will need to get more input else where, I thikn it best to post the problem on slack and get some other people to try too... I still can't get it to run. Just hangs... |
Turns out I'm actually an idiot and got the command line all wrong 🤦🏻 fixing right now |
So I added the |
I'm still new to nextflow. How would I define multiple bam inputs? I imagine would then be able to do something like EDIT: nvm, figured it out! I think this is good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments but looking pretty ready for me now!
$args \\ | ||
I=$bam \\ | ||
O=${prefix}.bam \\ | ||
M=${prefix}.metrics.txt \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you reverted back to metrics
, is that required by the tool in the end?
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Not required, but I noticed some other tools used for marking duplicates (picard, bammarkduplicates2) use the same convention, so I decided to stick with it for the sake of continuity |
Feel free to merge if everything looks ok to you! |
Oh really? they were early tools so maybe that was before the guidlines were confirmed... Hm ok. Fair enough then! |
Thanks for the help and review. Lots more to come! |
Add biobambam/bamsormadup
fixes #1479
PR checklist
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware