Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last changes to release 1.0.0 #23

Merged
merged 10 commits into from
Oct 24, 2022
Merged

Last changes to release 1.0.0 #23

merged 10 commits into from
Oct 24, 2022

Conversation

carpanz
Copy link
Collaborator

@carpanz carpanz commented Oct 24, 2022

This PR contains all last missing suggestions.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/hgtseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@carpanz carpanz requested review from jfy133 and lescai October 24, 2022 11:59
@github-actions
Copy link

github-actions bot commented Oct 24, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6e32399

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-10-24 12:24:43

Copy link
Collaborator

@lescai lescai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an ok from me, with please request to go ahead.
Any outstanding item will be addressed in next release.

@carpanz carpanz merged commit 4cd916f into master Oct 24, 2022
@jfy133 jfy133 mentioned this pull request Oct 24, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants