Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drone #5724

Merged
merged 2 commits into from
Jul 14, 2017
Merged

Fix drone #5724

merged 2 commits into from
Jul 14, 2017

Conversation

MorrisJobke
Copy link
Member

No description provided.

@MorrisJobke MorrisJobke added the 2. developing Work in progress label Jul 14, 2017
@codecov
Copy link

codecov bot commented Jul 14, 2017

Codecov Report

Merging #5724 into master will increase coverage by 18.51%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #5724       +/-   ##
=============================================
+ Coverage     35.35%   53.86%   +18.51%     
  Complexity    22755    22755               
=============================================
  Files          1405     1405               
  Lines         86741    86711       -30     
  Branches       1328     1328               
=============================================
+ Hits          30665    46705    +16040     
+ Misses        56076    40006    -16070
Impacted Files Coverage Δ Complexity Δ
tests/redis.config.php 10% <0%> (-90%) 0 <0> (ø)
apps/encryption/appinfo/app.php 0% <0%> (-100%) 0% <0%> (ø)
apps/encryption/lib/AppInfo/Application.php 73.03% <0%> (-24.45%) 9% <0%> (ø)
apps/encryption/lib/HookManager.php 66.66% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Files/View.php 85.86% <0%> (+0.21%) 363% <0%> (ø) ⬇️
lib/private/Server.php 93.44% <0%> (+0.29%) 120% <0%> (ø) ⬇️
lib/private/Files/Filesystem.php 67.18% <0%> (+0.38%) 119% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 87.04% <0%> (+0.51%) 62% <0%> (ø) ⬇️
... and 513 more

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 14, 2017
@MorrisJobke
Copy link
Member Author

@danxuliu @icewind1991 I needed to disable the acceptance and object storage tests temporarily because they rely on the fact, that the service (selenium and fake-s3) on localhost, but actually with drone 0.7 this is not the case anymore (because they matched with the docker-compose behaviour). Now we need to use the hostnames selenium and fake-s3 to connect to those services and I was not quickly able to do this change. But to let not fail all the other PRs I would go for merging this and then bring back those CI jobs soonish with separate PRs.

autotest.sh Outdated
@@ -46,6 +46,8 @@ function print_syntax {
echo -e "\nIf no arguments are specified, all tests will be run with all database configs" >&2
}

pwd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no :P

Fix service container host name
check current folder
fix redis for integration test
Fix more hostnames

Signed-off-by: Morris Jobke <[email protected]>
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drone seems happy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants