Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added headings #23

Closed
wants to merge 1 commit into from
Closed

added headings #23

wants to merge 1 commit into from

Conversation

PatrycjaPuczko
Copy link
Member

I put headings for the sections to make form more readable for users.
@nextcloud/contacts How can a get the real names for the headings instead of using {{prop.$key}?

Signed-off-by: Patrycja Romanowska-Puczko <[email protected]>
@PatrycjaPuczko PatrycjaPuczko added enhancement New feature or request 2. developing Work in progress design Related to the design labels Oct 29, 2016
@Henni
Copy link
Member

Henni commented Oct 29, 2016

I believe you can at the moment only hotfix this with {{prop.$key}}.
My suggestion how to solve this cleanly would be to:

  1. create a new angular directive (detailgroup) which would encapsulate all detailitems of the same type and display the heading (which is currently only accessible inside the detailsitem directive as {{ctrl.meta.readableName}}) or
  2. restructure the detailitem directive to list all entries of a single type.

"Graphically" this means:
Current State:

contact
|--detailitem (Name)
|--detailitem (Phone Work)
+--detailitem (Phone Home)

Suggestion 1:

contact
|-- detailgroup (Name)
|   +-- detailitem (Name)
+-- detailgroup (Phone)
    |--detailitem (Phone Work)
    +--detailitem (Phone Home)

Suggestion 2:

contact
|-- detailitem (Name)
+-- detailitem (Phone Work + Home)

cc @irgendwie thoughts?

@jancborchardt
Copy link
Member

@Henni @irgendwie do we want to check this out at the next meetup maybe? :)

@jancborchardt
Copy link
Member

@Henni suggestion 1 seems most fitting, right? @nextcloud/contacts is some of you down for implementing that?

@skjnldsv
Copy link
Member

We'll need a full restructuration of the details.
Since no activity, closing. We'll work on a full rewriting later :)

@skjnldsv skjnldsv closed this Feb 18, 2017
@jancborchardt
Copy link
Member

Why a full restructuring @skjnldsv? :) Can’t we do this step by step? And this is already a good step in the right direction. We just need the actual text value.

@jancborchardt
Copy link
Member

@Henni let me know as soon as you have the follow-up pull request to this open. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress design Related to the design enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants